-
Notifications
You must be signed in to change notification settings - Fork 99
Modularize project to run 2 application within the same codebase #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Modularize project to run 2 application within the same codebase #537
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
@andrewtavis I had some queries related to adding in the Contributing and README changes which I will state here in a minute |
b2609cc to
f885429
Compare
|
Currently I have made the flavours of the codebase hasn't been divided into the what's required for keyboard and conjugate app as I felt it would be better that would be done as would develop the conjugate application. My idea would be to break the modules off the main app module once we have divided the codebase properly and then we would have a similar structure to FireFox and BitWarden. This would make our work much easier as currently the entire existing main is being shared between the two apps for now as we slowly develop the application we would bring the components used by the individual application to their individual modules. My idea is to merge this in and then I would like to bring in and then create an issue on a roadmap for this as we wouldn't forget this. As for the contribution and other guidelines should I add a detailed description of it or should I just add a discrete description and then link the official docs. |
|
The tests failed as we have to change the workflow file a bit. I will do that in a moment. |
|
To change flavour. We have to click on the top bar button of Build and then select the option select build variant and then choose the variant we would like. |
|
Thanks for the PR, @angrezichatterbox! Let's bring in #536 from @bhanu-dev82 and then we can move to bringing this in :) Let us know if you have any suggestions here as well, @bhanu-dev82 😊 Purpose of this is setting up the project such that we can maintain two projects in this repo, just so we do the initial work before the release of the keyboard app. |
|
I have changed the app icon and also make the app label as Conjugate for now. |
|
Thanks for the work to split the project, @angrezichatterbox! So great to see this 😊 I'm getting an error when I try to build: Do you have suggestions of how to fix this? |
|
Are you using an older version of Android Studio ? |
|
Android Studio Otter 2 Feature Drop | 2025.2.2 This is my version |
|
Good suggestion. I'm now on Otter 3, and the project builds, but when I try to run it on a Pixel 9 emulator with Android 36 I'm getting: |
|
We can also do a quick call at some point to check Android Studio setups and then bring this in :) Do we have the current suggested Android Studio and any other settings documented somewhere? Would be nice to have that in the readme and contributing guide and then we can let the community know when updates should happen :) |
https://stackoverflow.com/questions/45746049/how-to-run-different-product-flavors-in-android-studio I wanted to add this but didn't know how to properly add it. |
Could you try restarting your simulator once again. or deleting and creating a new one |
We could bring this in during the sync if we have time :) |
|
100% we can check this during the sync if it's not in before :) |
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Amazing that we have this finished up for both applications, @angrezichatterbox! 😊 Looking forward to starting to work on the new functionality :)
|
I have made the changes in readme and contributions guide. Could you please review it when you are free :) |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR adds flavours to the application. The Keyboard flavour would be the default and running the application would bring in the Keyboard application. However changing the flavour to conjugate would bring in the conjugate application which currently displays a sample application.
Related issue